feat: include source code #1126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| datasource | package | from | to | | ---------- | ----------------- | ------ | ------ | | docker | docker/dockerfile | 1.10.0 | 1.15.1 |
* remove 3.7.1 and 3.8.0 * add 4.0.0 * update changelog * bump to java 23 for kafka 4.0.0 * fix kcat image name
* chore: stop building kcat image * fix: adjust kafka / kafka-testing-tools watched paths
…into feat/include-sourcecode
…into feat/include-sourcecode
maltesander
requested changes
May 26, 2025
Co-authored-by: Malte Sander <[email protected]>
…into feat/include-sourcecode
|
@maltesander Thanks, I moved the |
dervoeti
force-pushed
the
feat/include-sourcecode
branch
from
c6140a4 to
b6a190a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1069
This PR adds .tar.gz files containing the source code (including our custom patches) that was used to build the products into the container images. This should help with debugging and further increase transparency, while the costs are relatively low.
I also migrated a few components to fetch the source code using patchable. The goal is to use the same process everywhere to fetch source code (clone it from a Github repository that is part of the stackabletech org), even if we don't patch the source code.
The following components were migrated to use
patchable:./autogen.sh(along with its dependencies,automakeandlibtool), since the code of the Github repo differed from the snapshot we have in Nexus (for example, in Nexus the./configurescript is already present). This is also the exact same way Hadoop does it./stackable/src/hbase-operator-toolsto/stackable/src/hbase/hbase-operator-toolsto align with the structure in docker-images and all the other componentsDefinition of Done Checklist
Note
Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.
Please make sure all these things are done and tick the boxes
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
baketo retrieve the image tag for<image-tagged-with-the-major-version>.